📦 deps(skills): sync thirdparty skills

This commit is contained in:
ci[bot]
2026-08-12 12:41:45 +08:00
parent a0131f52c6
commit 073dac13a3
101 changed files with 5290 additions and 3529 deletions
+8 -6
View File
@@ -18,15 +18,17 @@ description: >
## Setup
1. Read `../_shared/common.md` for the Iron Law, Project Config, Report Template, and Health Score rules
2. Read `../_shared/source-coverage.md` for book-level coverage, exceptions, and tradeoffs
3. Read `../_shared/test-decay-risks.md` for test-space symptom definitions and source attributions
4. Read `test-guide.md` in this directory for the test quality review framework
Read in order:
1. `../_shared/common.md` — Iron Law, Project Config, Report Template, Health Score
2. `../_shared/source-coverage.md` — book coverage, exceptions, tradeoffs
3. `../_shared/test-decay-risks.md` — test-space symptom definitions and sources
4. `test-guide.md` (this directory) — the test quality review framework
## Process
**If the user has not shared test files or pointed to a test directory:** apply Auto
Scope Detection from `../_shared/common.md` to determine the review scope before proceeding.
**Scope:** if the user did not share test files or point to a test directory, apply Auto
Scope Detection (`../_shared/common.md`) first.
1. Build the test suite map (guide's "Before You Start" section)
2. Scan for each test decay risk in the order specified (Steps 14 of the guide)
+9 -7
View File
@@ -62,8 +62,7 @@ Look for:
to the observable behavior?
- Are tests coupled to private methods or internal state directly?
If brittleness is systemic (most tests in the file break on a rename) → 🔴 Critical.
If isolated (12 brittle tests) → 🟢 Suggestion.
Severity: use the T2 Severity Guide in `../_shared/test-decay-risks.md`.
### Step 2b: Scan for Mock Abuse
@@ -97,8 +96,8 @@ Look for:
- Is the same business scenario covered at unit, integration, and E2E level with no
difference in what each layer is testing?
If duplication is systemic (10 or more instances) → Critical.
If localized (35 instances) → Warning.
Severity: use the T3 Severity Guide in `../_shared/test-decay-risks.md`, with instance
counts as the tiebreaker — 🔴 10+ instances, 🟡 39, 🟢 12.
### Step 4: Scan for Coverage Illusion and Architecture Mismatch
@@ -131,9 +130,12 @@ Look for Architecture Mismatch:
**Test suite performance:** A slow test suite is a first-class maintainability risk — it
breaks the fast-feedback loop and causes developers to skip running tests locally.
- If the full suite runtime is known and > 10 minutes → 🟡 Warning
- If the full suite runtime is > 30 minutes or unknown → 🔴 Critical (unknown suite time
means nobody is running it regularly)
- If the full suite runtime is > 10 minutes → 🟡 Warning (per the T6 Severity Guide in
`../_shared/test-decay-risks.md`; runtime alone does not reach Critical)
- Runtime > 30 minutes, or unknown because nobody runs the suite, is still 🟡 Warning —
but say so explicitly in the Symptom. It reaches 🔴 Critical only when combined with a
Critical T6 condition: legacy code under modification with no seams and no
characterization tests, or a fully inverted pyramid
- If tests that could be unit tests are integration tests, that is a Performance Mismatch:
each misclassified test adds seconds of avoidable wait time