Merge branch 'main' of https://git.mytsl.cn/csh/playbook
This commit is contained in:
commit
e9ddc1e0b3
|
|
@ -5,8 +5,7 @@ description: >
|
|||
flags structural decay across a codebase, drawing on twelve classic engineering books.
|
||||
Triggers when: user asks to audit architecture, review folder/module structure,
|
||||
check for circular imports, understand how the codebase is organized, or asks
|
||||
"does this follow clean architecture?", "why does everything depend on everything?",
|
||||
"are our layers correct?", "where should this code live?".
|
||||
"does this follow clean architecture?" or "why does everything depend on everything?".
|
||||
Also triggers for onboarding requests: "explain this codebase to a new developer"
|
||||
or "give me a codebase tour" (use onboarding mode).
|
||||
Do NOT trigger for: PR-level code review (use brooks-review) or line-level refactoring
|
||||
|
|
|
|||
|
|
@ -5,9 +5,8 @@ description: >
|
|||
problems — helping teams build a refactoring roadmap — drawing on twelve classic
|
||||
engineering books.
|
||||
Triggers when: user asks about tech debt, refactoring priorities, what to clean up
|
||||
first, or asks "why is this so hard to change?", "where's the most painful part?",
|
||||
"what should we fix first?", "how do I justify refactoring to management?",
|
||||
"why is our velocity dropping?".
|
||||
first, or asks "why is this so hard to change?", "what should we fix first?", or
|
||||
"how do I justify refactoring to management?".
|
||||
Do NOT trigger for: server health checks, HTTP /health endpoints, Kubernetes probes,
|
||||
database health, or application uptime — "health" in those contexts is infrastructure,
|
||||
not code quality. Also not for single-function refactoring questions.
|
||||
|
|
|
|||
|
|
@ -5,9 +5,8 @@ description: >
|
|||
dimensions — PR quality, architecture, tech debt, and test quality — in a single
|
||||
pass, drawing on twelve classic engineering books.
|
||||
Triggers when: user wants an overall quality assessment, asks "how healthy is this
|
||||
codebase?", "run all the checks", "give me a big-picture quality report", "I need a
|
||||
health score before the release", "what's the overall state of our code?", or wants
|
||||
to onboard a new team with a quality overview.
|
||||
codebase?", "run all the checks", "I need a health score before the release", or
|
||||
wants to onboard a new team with a quality overview.
|
||||
Do NOT trigger for: server health checks, HTTP health endpoints, Kubernetes
|
||||
liveness/readiness probes, database health, or application uptime. Also do not
|
||||
trigger when the user specifically requests only one dimension — use the
|
||||
|
|
|
|||
|
|
@ -8,9 +8,8 @@ description: >
|
|||
code asking "does this look right?" / "any issues here?" / "ready to merge?",
|
||||
or asks for feedback on a function, class, or file.
|
||||
Also triggers when user mentions: code smells / refactoring / clean architecture /
|
||||
DDD / domain-driven design / SOLID principles / Hyrum's Law / deep modules /
|
||||
tactical programming / conceptual integrity / Brooks's Law / Mythical Man-Month /
|
||||
second system effect.
|
||||
DDD / SOLID principles / Hyrum's Law / deep modules / tactical programming /
|
||||
conceptual integrity / Brooks's Law / Mythical Man-Month / second system effect.
|
||||
Do NOT trigger for: questions about how to write code from scratch, language syntax
|
||||
questions, or framework/tool questions where no existing code is shared.
|
||||
---
|
||||
|
|
|
|||
|
|
@ -6,12 +6,12 @@ description: >
|
|||
codebase. Safe changes are auto-applied; risky changes are confirmed before
|
||||
execution. Drawing on twelve classic engineering books.
|
||||
Triggers when: user wants to "fix everything", "sweep the codebase", "auto-fix all
|
||||
issues", "run all checks and fix them", "clean up the whole project", or asks for
|
||||
a single command that both diagnoses and remediates quality problems.
|
||||
issues", "clean up the whole project", or asks for a single command that both
|
||||
diagnoses and remediates quality problems.
|
||||
Do NOT trigger for: read-only audits or health reports where the user only wants
|
||||
findings without code changes; single-dimension reviews (use the focused skill
|
||||
instead: brooks-review / brooks-audit / brooks-debt / brooks-test); server health
|
||||
checks, HTTP /health endpoints, Kubernetes probes, or application uptime.
|
||||
checks, HTTP /health endpoints, Kubernetes probes, database health, or application uptime.
|
||||
---
|
||||
|
||||
# Brooks-Lint — Full Sweep & Auto-Fix
|
||||
|
|
|
|||
|
|
@ -8,8 +8,7 @@ description: >
|
|||
poor readability.
|
||||
Triggers when: user asks about test quality, shares test files for review, or
|
||||
expresses frustration: "tests keep breaking whenever I change anything", "our tests
|
||||
take forever", "I can't understand what this test is doing", "tests pass but bugs
|
||||
still reach production", "we have too many mocks".
|
||||
take forever", "tests pass but bugs still reach production", or "we have too many mocks".
|
||||
Do NOT trigger for: writing new tests from scratch (use the regular test-writing
|
||||
workflow) or testing framework/syntax questions — this skill reviews an existing
|
||||
suite for structural quality problems, not individual test authoring.
|
||||
|
|
|
|||
Loading…
Reference in New Issue