csh/tsl-devkit
1
1
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

🎨 style(core): normalize lifecycle implementation

Browse Source
This commit is contained in:
csh
2026-07-14 12:08:09 +08:00
parent 12e1a87b2b
commit 5a02bd10f9
3 changed files with 38 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lsp-server/src/core/dispatcher.cppm
+3 -4
View File
@@ -45,8 +45,7 @@ export namespace lsp::core
public: public:
ExecutionContext(scheduler::async_executor::AsyncExecutor& scheduler, ExecutionContext(scheduler::async_executor::AsyncExecutor& scheduler,
manager::ManagerHub& manager_hub, manager::ManagerHub& manager_hub,
std::stop_token stop_token = {}) std::stop_token stop_token = {}) : async_executor_(scheduler),
: async_executor_(scheduler),
manager_hub_(manager_hub), manager_hub_(manager_hub),
stop_token_(stop_token) stop_token_(stop_token)
{ {
@@ -120,8 +119,8 @@ namespace lsp::core
{ {
RequestDispatcher::RequestDispatcher( RequestDispatcher::RequestDispatcher(
scheduler::async_executor::AsyncExecutor& scheduler, scheduler::async_executor::AsyncExecutor& scheduler,
manager::ManagerHub& manager_hub) manager::ManagerHub& manager_hub) : async_executor_(scheduler),
: async_executor_(scheduler), manager_hub_(manager_hub) manager_hub_(manager_hub)
{ {
} }
lsp-server/test/test_provider/provider_misc_test.cppm
+4 -8
View File
@@ -171,8 +171,7 @@ namespace lsp::test::provider
manager::ManagerHub hub{}; manager::ManagerHub hub{};
core::ExecutionContext context; core::ExecutionContext context;
ProviderEnv() ProviderEnv() : context(scheduler, hub)
: context(scheduler, hub)
{ {
hub.Initialize(); hub.Initialize();
} }
@@ -1411,8 +1410,7 @@ namespace lsp::test::provider
auto tooltip_it = resolved.find("tooltip"); auto tooltip_it = resolved.find("tooltip");
assertTrue(tooltip_it != resolved.end(), "InlayHint resolve should set tooltip"); assertTrue(tooltip_it != resolved.end(), "InlayHint resolve should set tooltip");
assertTrue(tooltip_it->second.Is<protocol::string>(), "InlayHint tooltip should be string"); assertTrue(tooltip_it->second.Is<protocol::string>(), "InlayHint tooltip should be string");
assertEqual(std::string("param: int"), tooltip_it->second.Get<protocol::string>(), assertEqual(std::string("param: int"), tooltip_it->second.Get<protocol::string>(), "InlayHint tooltip should use detail");
"InlayHint tooltip should use detail");
return result; return result;
} }
@@ -2891,10 +2889,8 @@ namespace lsp::test::provider
{ {
protocol::LSPObject diagnostic; protocol::LSPObject diagnostic;
diagnostic["range"] = protocol::LSPObject{ diagnostic["range"] = protocol::LSPObject{
{ "start", protocol::LSPObject{ { "line", static_cast<protocol::integer>(error.location.start_line) }, { "start", protocol::LSPObject{ { "line", static_cast<protocol::integer>(error.location.start_line) }, { "character", static_cast<protocol::integer>(error.location.start_column) } } },
{ "character", static_cast<protocol::integer>(error.location.start_column) } } }, { "end", protocol::LSPObject{ { "line", static_cast<protocol::integer>(error.location.end_line) }, { "character", static_cast<protocol::integer>(error.location.end_column) } } },
{ "end", protocol::LSPObject{ { "line", static_cast<protocol::integer>(error.location.end_line) },
{ "character", static_cast<protocol::integer>(error.location.end_column) } } },
}; };
diagnostic["message"] = error.message; diagnostic["message"] = error.message;
diagnostics.emplace_back(std::move(diagnostic)); diagnostics.emplace_back(std::move(diagnostic));
lsp-server/test/test_provider/provider_surface_test.cppm
+3 -6
View File
@@ -114,8 +114,7 @@ namespace lsp::test::provider
manager::ManagerHub hub{}; manager::ManagerHub hub{};
core::ExecutionContext context; core::ExecutionContext context;
ProviderEnv() ProviderEnv() : context(scheduler, hub)
: context(scheduler, hub)
{ {
hub.Initialize(); hub.Initialize();
} }
@@ -126,10 +125,8 @@ namespace lsp::test::provider
const std::string& expected_name) const std::string& expected_name)
{ {
Provider provider; Provider provider;
assertEqual(expected_method, provider.GetMethod(), assertEqual(expected_method, provider.GetMethod(), "GetMethod mismatch for " + expected_name);
"GetMethod mismatch for " + expected_name); assertEqual(expected_name, provider.GetProviderName(), "GetProviderName mismatch for " + expected_name);
assertEqual(expected_name, provider.GetProviderName(),
"GetProviderName mismatch for " + expected_name);
} }
template<typename Provider> template<typename Provider>